linux-kernel - Re: [PATCH v5 5/7] drm/vkms: Support enabling ConfigFS devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202308282031.pHgZz2pY-lkp@intel.com>
Date:   Mon, 28 Aug 2023 20:52:00 +0800
From:   kernel test robot <lkp@...el.com>
To:     Brandon Pollack <brpol@...omium.org>, marius.vlad@...labora.com,
        mairacanal@...eup.net, jshargo@...omium.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        hamohammed.sa@...il.com, rodrigosiqueiramelo@...il.com,
        linux-doc@...r.kernel.org, hirono@...omium.org, corbet@....net,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        melissa.srw@...il.com, mduggan@...omium.org, mripard@...nel.org,
        tzimmermann@...e.de, Brandon Pollack <brpol@...omium.org>
Subject: Re: [PATCH v5 5/7] drm/vkms: Support enabling ConfigFS devices

Hi Brandon,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on next-20230828]
[cannot apply to linus/master v6.5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Brandon-Pollack/drm-vkms-Back-VKMS-with-DRM-memory-management-instead-of-static-objects/20230828-162136
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20230828081929.3574228-6-brpol%40chromium.org
patch subject: [PATCH v5 5/7] drm/vkms: Support enabling ConfigFS devices
config: x86_64-randconfig-r015-20230828 (https://download.01.org/0day-ci/archive/20230828/202308282031.pHgZz2pY-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230828/202308282031.pHgZz2pY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308282031.pHgZz2pY-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/vkms/vkms_output.c:180: warning: Function parameter or member 'vkmsdev' not described in 'validate_vkms_configfs_no_dangling_objects'


vim +180 drivers/gpu/drm/vkms/vkms_output.c

   166	
   167	/**
   168	* validate_vkms_configfs_no_dangling_objects - warn on unused objects in vkms
   169	* configfs.
   170	* @vkmsdev vkms device
   171	*
   172	* This gives slightly more visible warning messaging to the user before the drm
   173	* system finds the configuration invalid and prints it's debug information.  In
   174	* this case the user may have accidentally not included some links, or the user
   175	* could be testing this faulty configuration.
   176	*
   177	*/
   178	static void
   179	validate_vkms_configfs_no_dangling_objects(struct vkms_device *vkmsdev)
 > 180	{
   181		struct vkms_configfs *configfs = vkmsdev->configfs;
   182		struct config_item *item;
   183	
   184		// 1. Planes
   185		list_for_each_entry(item, &configfs->planes_group.cg_children,
   186				    ci_entry) {
   187			struct vkms_config_plane *config_plane =
   188				item_to_config_plane(item);
   189			if (config_plane->possible_crtcs.linked_object_bitmap == 0)
   190				DRM_WARN(
   191					"Vkms configfs created plane %s has no linked crtcs",
   192					item->ci_name);
   193		}
   194	
   195		// 2. connectors
   196		list_for_each_entry(item, &configfs->connectors_group.cg_children,
   197				    ci_entry) {
   198			struct vkms_config_connector *config_connector =
   199				item_to_config_connector(item);
   200			if (config_connector->possible_encoders.linked_object_bitmap ==
   201			    0) {
   202				DRM_WARN(
   203					"Vkms configfs created connector %s has no linked encoders",
   204					item->ci_name);
   205			}
   206		}
   207	
   208		// 3. encoders
   209		list_for_each_entry(item, &configfs->encoders_group.cg_children,
   210				    ci_entry) {
   211			struct vkms_config_encoder *config_encoder =
   212				item_to_config_encoder(item);
   213			if (config_encoder->possible_crtcs.linked_object_bitmap == 0) {
   214				DRM_WARN(
   215					"Vkms configfs created encoder %s has no linked crtcs",
   216					item->ci_name);
   217			}
   218		}
   219	
   220		// 4. crtcs only require a primary plane to function, this is checked during
   221		// output initialization and returns an error.
   222	}
   223	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki