linux-kernel - Re: [PATCH 4/6] selftests/pidfd: Fix ksft print formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bis4cb4nawx32ys4aqjytksw4oyhzhocfvarintru4ow2oqsjv@ph73qvhn77gg>
Date:   Mon, 28 Aug 2023 15:07:23 +0200
From:   Maciej Wieczór-Retman 
        <maciej.wieczor-retman@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC:     Christian Brauner <brauner@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Reinette Chatre <reinette.chatre@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH 4/6] selftests/pidfd: Fix ksft print formats

On 2023-08-28 at 14:01:18 +0300, Ilpo Järvinen wrote:
>On Mon, 28 Aug 2023, Wieczor-Retman, Maciej wrote:
>> Signed-off-by: Wieczor-Retman, Maciej <maciej.wieczor-retman@...el.com>
>> ---
>>  tools/testing/selftests/pidfd/pidfd_fdinfo_test.c |  2 +-
>>  tools/testing/selftests/pidfd/pidfd_test.c        | 12 ++++++------
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>> 
>> diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
>> index 4e86f927880c..01cc37bf611c 100644
>> --- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
>> +++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
>> @@ -62,7 +62,7 @@ static void error_report(struct error *err, const char *test_name)
>>  		break;
>>  
>>  	case PIDFD_PASS:
>> -		ksft_test_result_pass("%s test: Passed\n");
>> +		ksft_test_result_pass("%s test: Passed\n", test_name);
>
>Missing test_name leads to crash so this looks a Fixes: class thing for
>me but you didn't provide one.

Thanks, I'll add this tag.

In my case it just gives a warning but compiles anyway:

pidfd_fdinfo_test.c: In function ‘error_report’:
pidfd_fdinfo_test.c:65:41: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat=]
   65 |                 ksft_test_result_pass("%s test: Passed\n");
      |                                        ~^
      |                                         |
      |                                         char *

Could I be missing some strict config?

-- 
Kind regards
Maciej Wieczór-Retman