[<prev] [next>] [day] [month] [year] [list]
Message-ID: <PH7PR11MB7643E52AF72688CEFDA4DAFABCE0A@PH7PR11MB7643.namprd11.prod.outlook.com>
Date: Mon, 28 Aug 2023 09:39:19 -0400
From: Oliver Crumrine <ozlinux@...mail.com>
To: gregkh@...uxfoundation.org, colin.i.king@...il.com,
sumitraartsy@...il.com, u.kleine-koenig@...gutronix.de,
geert@...ux-m68k.org
Cc: Oliver Crumrine <ozlinux@...mail.com>,
linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: [PATCH v4 6/6] staging: octeon: clean up the octeon ethernet driver
Make the octeon ethernet driver better adhere to the
kernel coding standard
Signed-off-by: Oliver Crumrine <ozlinux@...mail.com>
---
v2: Actually send the patch set properly
v3: Fixed a bug where I forgot to change all instances of a struct
v4: Actually fix that bug (this is my first patch, give me a break)
drivers/staging/octeon/ethernet.c | 4 ++--
drivers/staging/octeon/octeon-stubs.h | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 023b107e077a..8e1f4b987a25 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -201,8 +201,8 @@ EXPORT_SYMBOL(cvm_oct_free_work);
*/
static struct net_device_stats *cvm_oct_common_get_stats(struct net_device *dev)
{
- cvmx_pip_port_status_t rx_status;
- cvmx_pko_port_status_t tx_status;
+ struct cvmx_pip_port_status rx_status;
+ struct cvmx_pko_port_status tx_status;
struct octeon_ethernet *priv = netdev_priv(dev);
if (priv->port < CVMX_PIP_NUM_INPUT_PORTS) {
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index b9852994882b..579c755cfdc0 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -384,7 +384,7 @@ union cvmx_ipd_sub_port_qos_cnt {
} s;
};
-typedef struct {
+struct cvmx_pip_port_status {
uint32_t dropped_octets;
uint32_t dropped_packets;
uint32_t pci_raw_packets;
@@ -407,13 +407,13 @@ typedef struct {
uint32_t inb_packets;
uint64_t inb_octets;
uint16_t inb_errors;
-} cvmx_pip_port_status_t;
+};
-typedef struct {
+struct cvmx_pko_port_status {
uint32_t packets;
uint64_t octets;
uint64_t doorbell;
-} cvmx_pko_port_status_t;
+};
union cvmx_pip_frm_len_chkx {
uint64_t u64;
@@ -1258,11 +1258,11 @@ static inline int octeon_is_simulation(void)
}
static inline void cvmx_pip_get_port_status(uint64_t port_num, uint64_t clear,
- cvmx_pip_port_status_t *status)
+ struct cvmx_pip_port_status *status)
{ }
static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t clear,
- cvmx_pko_port_status_t *status)
+ struct cvmx_pko_port_status *status)
{ }
static inline enum cvmx_helper_interface_mode cvmx_helper_interface_get_mode(int
--
2.39.3
Powered by blists - more mailing lists