[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230828144820.5552aa0a@jic23-huawei>
Date: Mon, 28 Aug 2023 14:48:20 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: <Marius.Cristea@...rochip.com>
Cc: <devicetree@...r.kernel.org>, <conor+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <lars@...afoo.de>,
<linux-iio@...r.kernel.org>, <robh+dt@...nel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] iio: adc: adding support for MCP3564 ADC
On Fri, 18 Aug 2023 16:29:26 +0000
<Marius.Cristea@...rochip.com> wrote:
> Hi Jonathan,
>
> >
> > > @@ -0,0 +1,53 @@
> > > +What:
> > > /sys/bus/iio/devices/iio:deviceX/boost_current
> > > +KernelVersion: 6.4
> > > +Contact: linux-iio@...r.kernel.org
> > > +Description:
> > > + This attribute is used to set the biasing circuit of
> > > the
> > > + Delta-Sigma modulator. The different BOOST settings
> > > are applied
> > > + to the entire modulator circuit, including the
> > > voltage reference
> > > + buffers.
> >
> > Units? Should be mA given that is what we use for other current
> > attributes
> > in IIO.
> >
>
> This should have no units because is a "gain" for the bias current. I
> think it will be better to change the name of the attribute to
> "boost_current_gain".
That's sounds reasonable to me as well.
>
>
> > This one may cause us problems with generality of the description if
> > we reuse
> > if for other devices (and hence move it to the more general files),
> > but we
> > can figure this out at the time.
> >
> > >
>
> Thanks and Best Regards,
> Marius
>
Powered by blists - more mailing lists