[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <PAXPR04MB9185957B729588D3E7CA3A5089E0A@PAXPR04MB9185.eurprd04.prod.outlook.com>
Date: Mon, 28 Aug 2023 14:04:00 +0000
From: Shenwei Wang <shenwei.wang@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Ulf Hansson <ulf.hansson@...aro.org>
CC: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Saturday, August 26, 2023 12:32 PM
> To: Shenwei Wang <shenwei.wang@....com>; Ulf Hansson
> <ulf.hansson@...aro.org>
> Cc: Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley <conor+dt@...nel.org>;
> Liam Girdwood <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>;
> imx@...ts.linux.dev; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> dl-linux-imx <linux-imx@....com>
> Subject: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file
> > >
> > > regulator-number = <2>;
> > > regulator-0-supply = <®1>;
> > > regulator-1-supply = <®2>;
> > }; };
> >
> > Are you suggesting to move the regulator-pd to the imx directory and
> > add a company prefix to the compatible string?
>
> There is no such part of iMX processor as such regulator-power-domain, so I
> don't recommend that approach. DTS nodes represent hardware, not your SW
> layers.
>
That's not always the case, as we do sometimes need a virtual device.
As an example, the "regulator-fixed" acts as a software abstraction layer to create virtual regulator
devices by interfacing with the underlying GPIO drivers.
Similarly, "regulator-pd" provides a software abstraction layer for virtual PD devices built on
top of existing regulator drivers.
When looking at the conceptual purpose, regulator-fixed and regulator-pd are comparable in
that they both offer software abstraction layers for virtual devices."
Thanks,
Shenwei
> Best regards,
> Krzysztof
Powered by blists - more mailing lists