linux-kernel - Re: [PATCH v2 8/8] mm: migrate: remove isolated variable in add_page_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <879D24CB-B7C1-401D-8046-1FDF1A147BB1@nvidia.com>
Date:   Mon, 28 Aug 2023 10:18:20 -0400
From:   Zi Yan <ziy@...dia.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, willy@...radead.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        ying.huang@...el.com, david@...hat.com,
        Mike Kravetz <mike.kravetz@...cle.com>, hughd@...gle.com
Subject: Re: [PATCH v2 8/8] mm: migrate: remove isolated variable in
 add_page_for_migration()

On 21 Aug 2023, at 7:56, Kefeng Wang wrote:

> Directly check the return of isolate_hugetlb() and folio_isolate_lru()
> to remove isolated variable, also setup err = -EBUSY in advance before
> isolation, and update err only when successfully queued for migration,
> which could help us to unify and simplify code a bit.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>  mm/migrate.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>

LGTM. Reviewed-by: Zi Yan <ziy@...dia.com>

--
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)