linux-kernel - Re: [PATCH blktests v3 3/3] nvme: introduce nvmet_target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ffb6c2f-0836-4302-82b9-902e092e537c@acm.org>
Date:   Mon, 28 Aug 2023 08:14:31 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Shinichiro Kawasaki <shinichiro.kawasaki@....com>
Cc:     Daniel Wagner <dwagner@...e.de>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Hannes Reinecke <hare@...e.de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH blktests v3 3/3] nvme: introduce
 nvmet_target_{setup/cleanup} common code

On 8/27/23 21:13, Shinichiro Kawasaki wrote:
> For me, your original suggestion to add "ignored_agument" looks better
> than "$@". (or in short, "noarg" or something)

It is not clear to me what the intention is of the _nvmet_target_setup
calls without arguments. Is the intention to pass all arguments that have
been passed to the caller or is the intention not to pass any arguments?
In the latter case I think it would be wrong to suppress SC2119 because
there really is a problem in this case. How about passing -- as argument
if the intention is not to pass any arguments? It is a well established
convention for shell commands and shell functions to ignore the double
hyphen if it is encountered in the argument list.

Thanks,

Bart.