linux-kernel - Re: [PATCH] nvdimm: of_pmem: Add kfree for kstrdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <788c47b0-42f6-fc42-f293-00b14eee0673@intel.com>
Date:   Mon, 28 Aug 2023 08:49:41 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Chen Ni <nichen@...as.ac.cn>, <oohall@...il.com>,
        <dan.j.williams@...el.com>, <vishal.l.verma@...el.com>,
        <ira.weiny@...el.com>
CC:     <nvdimm@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvdimm: of_pmem: Add kfree for kstrdup



On 8/27/23 23:23, Chen Ni wrote:
> Add kfree() for kstrdup() in order to avoid memory leak.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Can you please add a fixes tag? Thanks!

> ---
>   drivers/nvdimm/of_pmem.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> index 10dbdcdfb9ce..fe6edb7e6631 100644
> --- a/drivers/nvdimm/of_pmem.c
> +++ b/drivers/nvdimm/of_pmem.c
> @@ -31,11 +31,17 @@ static int of_pmem_region_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	priv->bus_desc.provider_name = kstrdup(pdev->name, GFP_KERNEL);
> +	if (!priv->bus_desc.provider_name) {
> +		kfree(priv);
> +		return -ENOMEM;
> +	}
> +
>   	priv->bus_desc.module = THIS_MODULE;
>   	priv->bus_desc.of_node = np;
>   
>   	priv->bus = bus = nvdimm_bus_register(&pdev->dev, &priv->bus_desc);
>   	if (!bus) {
> +		kfree(priv->bus_desc.provider_name);
>   		kfree(priv);
>   		return -ENODEV;
>   	}