linux-kernel - Re: [PATCH v2] dmaengine: plx_dma: Fix potential deadlock on &plxdev->ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3545b782-756a-3d2a-d192-8b224a783c13@sw-optimization.com>
Date:   Mon, 28 Aug 2023 18:18:07 +0200
From:   Eric Schwarz <eas@...optimization.com>
To:     Chengfeng Ye <dg573847474@...il.com>
Cc:     yuyunbo519@...il.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, christophe.jaillet@...adoo.fr,
        vkoul@...nel.org, logang@...tatee.com
Subject: Re: [PATCH v2] dmaengine: plx_dma: Fix potential deadlock on
 &plxdev->ring_lock

Hello,

Am 29.07.2023 um 19:59 schrieb Chengfeng Ye:
> This flaw was found by an experimental static analysis tool I am developing
> for irq-related deadlock.

Just out of curiosity, did/could
- Linux kernel config checks like CONFIG_DEBUG_SPINLOCK option or
- Smatch [1]
find that issue too?

I have also found an article from Dan Carpenter on the net about lock 
checking capability of Smatch which relates IMHO to what you are doing [2].

The question is, whether the checks/algorithm what you have developed 
already exists in form of other tools or they might be added to an 
already existing one, which is already spread across the community and 
used accordingly.

Many thanks for your reply in advance.

[1] https://github.com/error27/smatch
[2] https://blogs.oracle.com/linux/post/writing-the-ultimate-locking-check

Cheers
Eric