linux-kernel - Re: [PATCH V4 4/7] cpufreq: Add a notification message that the highest perf has changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202308300057.ASUJQpsV-lkp@intel.com>
Date:   Wed, 30 Aug 2023 00:27:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Meng Li <li.meng@....com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Huang Rui <ray.huang@....com>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, linux-acpi@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>,
        linux-kselftest@...r.kernel.org,
        Nathan Fontenot <nathan.fontenot@....com>,
        Deepak Sharma <deepak.sharma@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Mario Limonciello <mario.limonciello@....com>,
        Shimmer Huang <shimmer.huang@....com>,
        Perry Yuan <Perry.Yuan@....com>,
        Xiaojian Du <Xiaojian.Du@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Borislav Petkov <bp@...en8.de>, Meng Li <li.meng@....com>
Subject: Re: [PATCH V4 4/7] cpufreq: Add a notification message that the
 highest perf has changed

Hi Meng,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linus/master v6.5 next-20230829]
[cannot apply to tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Meng-Li/x86-Drop-CPU_SUP_INTEL-from-SCHED_MC_PRIO-for-the-expansion/20230829-144723
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20230829064340.1136448-5-li.meng%40amd.com
patch subject: [PATCH V4 4/7] cpufreq: Add a notification message that the highest perf has changed
config: i386-randconfig-r031-20230829 (https://download.01.org/0day-ci/archive/20230830/202308300057.ASUJQpsV-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230830/202308300057.ASUJQpsV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308300057.ASUJQpsV-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/acpi/processor_driver.c:88:3: error: call to undeclared function 'cpufreq_update_highest_perf'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   cpufreq_update_highest_perf(pr->id);
                   ^
   1 error generated.


vim +/cpufreq_update_highest_perf +88 drivers/acpi/processor_driver.c

    53	
    54	static void acpi_processor_notify(acpi_handle handle, u32 event, void *data)
    55	{
    56		struct acpi_device *device = data;
    57		struct acpi_processor *pr;
    58		int saved;
    59	
    60		if (device->handle != handle)
    61			return;
    62	
    63		pr = acpi_driver_data(device);
    64		if (!pr)
    65			return;
    66	
    67		switch (event) {
    68		case ACPI_PROCESSOR_NOTIFY_PERFORMANCE:
    69			saved = pr->performance_platform_limit;
    70			acpi_processor_ppc_has_changed(pr, 1);
    71			if (saved == pr->performance_platform_limit)
    72				break;
    73			acpi_bus_generate_netlink_event(device->pnp.device_class,
    74							  dev_name(&device->dev), event,
    75							  pr->performance_platform_limit);
    76			break;
    77		case ACPI_PROCESSOR_NOTIFY_POWER:
    78			acpi_processor_power_state_has_changed(pr);
    79			acpi_bus_generate_netlink_event(device->pnp.device_class,
    80							  dev_name(&device->dev), event, 0);
    81			break;
    82		case ACPI_PROCESSOR_NOTIFY_THROTTLING:
    83			acpi_processor_tstate_has_changed(pr);
    84			acpi_bus_generate_netlink_event(device->pnp.device_class,
    85							  dev_name(&device->dev), event, 0);
    86			break;
    87		case ACPI_PROCESSOR_NOTIFY_HIGEST_PERF_CHANGED:
  > 88			cpufreq_update_highest_perf(pr->id);
    89			acpi_bus_generate_netlink_event(device->pnp.device_class,
    90							  dev_name(&device->dev), event, 0);
    91			break;
    92		default:
    93			acpi_handle_debug(handle, "Unsupported event [0x%x]\n", event);
    94			break;
    95		}
    96	
    97		return;
    98	}
    99	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki