linux-kernel - Re: [PATCH][next][V2] jfs: remove redundant initialization to pointer ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6974c489-3238-4037-81e5-3d9ec5e48ee0@oracle.com>
Date:   Tue, 29 Aug 2023 12:21:51 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Christian Brauner <brauner@...nel.org>,
        jfs-discussion@...ts.sourceforge.net
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next][V2] jfs: remove redundant initialization to pointer
 ip

On 8/18/23 10:02AM, Colin Ian King wrote:
> The pointer ip is being initialized with a value that is never read, it
> is being re-assigned later on. The assignment is redundant and can be
> removed.  Cleans up clang scan warning:
> 
> fs/jfs/namei.c:886:16: warning: Value stored to 'ip' during its
> initialization is never read [deadcode.DeadStores]

Looks good. Applied.

> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
> 
> V2: fix commit message "uninitialized" -> "initialized"
> 
> ---
>   fs/jfs/namei.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c
> index 029d47065600..57d7a4300210 100644
> --- a/fs/jfs/namei.c
> +++ b/fs/jfs/namei.c
> @@ -883,7 +883,7 @@ static int jfs_symlink(struct mnt_idmap *idmap, struct inode *dip,
>   	struct component_name dname;
>   	u32 ssize;		/* source pathname size */
>   	struct btstack btstack;
> -	struct inode *ip = d_inode(dentry);
> +	struct inode *ip;
>   	s64 xlen = 0;
>   	int bmask = 0, xsize;
>   	s64 xaddr;