linux-kernel - Re: [PATCH v2] cpufreq: governor: Free dbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iEV3s7QbngGv9Agq1VYO2bXUg3-kqdNeyUEN+N1sDV6g@mail.gmail.com>
Date:   Tue, 29 Aug 2023 20:22:37 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Liao Chang <liaochang1@...wei.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cpufreq: governor: Free dbs_data directly when
 gov->init() fails

On Tue, Aug 29, 2023 at 9:14 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 29-08-23, 07:03, Liao Chang wrote:
> > Due to the kobject embedded in the dbs_data doest not has a release()
> > method yet, it needs to use kfree() to free dbs_data directly when
> > governor fails to allocate the tunner field of dbs_data.
> >
> > Signed-off-by: Liao Chang <liaochang1@...wei.com>
> > ---
> >  drivers/cpufreq/cpufreq_governor.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
> > index 85da677c43d6..af44ee6a6430 100644
> > --- a/drivers/cpufreq/cpufreq_governor.c
> > +++ b/drivers/cpufreq/cpufreq_governor.c
> > @@ -439,7 +439,7 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy)
> >
> >       ret = gov->init(dbs_data);
> >       if (ret)
> > -             goto free_policy_dbs_info;
> > +             goto free_dbs_data;
> >
> >       /*
> >        * The sampling interval should not be less than the transition latency
> > @@ -474,6 +474,8 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy)
> >       if (!have_governor_per_policy())
> >               gov->gdbs_data = NULL;
> >       gov->exit(dbs_data);
> > +
> > +free_dbs_data:
> >       kfree(dbs_data);
> >
> >  free_policy_dbs_info:
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Applied as 6.6-rc material, thanks!