linux-kernel - Re: [RFC PATCH] mm/damon/core: add a tracepoint for damos apply target regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230829191629.25c5f0e2@rorschach.local.home>
Date:   Tue, 29 Aug 2023 19:16:29 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     SeongJae Park <sj@...nel.org>
Cc:     damon@...ts.linux.dev, Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm@...ck.org, linux-trace-kernel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] mm/damon/core: add a tracepoint for damos apply
 target regions

On Sun, 27 Aug 2023 00:40:45 +0000
SeongJae Park <sj@...nel.org> wrote:

> +	TP_STRUCT__entry(
> +		__field(unsigned int, context_idx)

4 bytes

> +		__field(unsigned int, scheme_idx)

4 bytes

> +		__field(unsigned long, target_idx)

8 bytes

> +		__field(unsigned int, nr_regions)

4 bytes

> +		__field(unsigned long, start)

This is going to cause a 4 byte hole. I would move nr_regions after end
so that it stays properly aligned.

-- Steve



> +		__field(unsigned long, end)
> +		__field(unsigned int, nr_accesses)
> +		__field(unsigned int, age)
> +	),
> +