[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <62bd6748-fedf-85c4-7416-7e620fa6b4f2@samba.org>
Date: Tue, 29 Aug 2023 18:23:01 -0500
From: Steven French <sfrench@...ba.org>
To: Katya Orlova <e.orlova@...ras.ru>,
David Howells <dhowells@...hat.com>
Cc: Jeff Layton <jlayton@...nel.org>,
Paulo Alcantara <pc@...guebit.com>,
Ronnie Sahlberg <lsahlber@...hat.com>,
linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org,
Steve French <smfrench@...il.com>
Subject: Re: [PATCH] smb: propagate error code of extract_sharename()
Merged into cifs-2.6.git for-next
On 8/15/23 08:38, Katya Orlova wrote:
> In addition to the EINVAL, there may be an ENOMEM.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 70431bfd825d ("cifs: Support fscache indexing rewrite")
> Signed-off-by: Katya Orlova <e.orlova@...ras.ru>
> ---
> fs/smb/client/fscache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/client/fscache.c b/fs/smb/client/fscache.c
> index 8f6909d633da..34e20c4cd507 100644
> --- a/fs/smb/client/fscache.c
> +++ b/fs/smb/client/fscache.c
> @@ -48,7 +48,7 @@ int cifs_fscache_get_super_cookie(struct cifs_tcon *tcon)
> sharename = extract_sharename(tcon->tree_name);
> if (IS_ERR(sharename)) {
> cifs_dbg(FYI, "%s: couldn't extract sharename\n", __func__);
> - return -EINVAL;
> + return PTR_ERR(sharename);
> }
>
> slen = strlen(sharename);
Powered by blists - more mailing lists