[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAAhV-H4xxSeoF9Nu65jwMjV5dbywyue6rJvkW9yoVHVEjL93Fg@mail.gmail.com>
Date: Tue, 29 Aug 2023 12:13:14 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Qing Zhang <zhangqing@...ngson.cn>,
Hui Li <lihui@...ngson.cn>,
Binbin Zhou <zhoubinbin@...ngson.cn>,
WANG Xuerui <kernel@...0n.name>, loongarch@...ts.linux.dev
Subject: Re: [PATCH 1/2] Loongarch: KGDB: fix implicit declaration of flush_icache_range()
Hi, Randy,
On Tue, Aug 29, 2023 at 8:23 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Add <asm/cacheflush.h> to prevent a build error:
>
> arch/loongarch/kernel/kgdb.c: In function 'do_single_step':
> arch/loongarch/kernel/kgdb.c:440:9: error: implicit declaration of function 'flush_icache_range' [-Werror=implicit-function-declaration]
> 440 | flush_icache_range(addr, addr + BREAK_INSTR_SIZE);
Thank you for your fixing, this will be included in linux-next.
Huacai
>
> Fixes: 8968eb010689 ("LoongArch: Add basic KGDB & KDB support")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Qing Zhang <zhangqing@...ngson.cn>
> Cc: Hui Li <lihui@...ngson.cn>
> Cc: Binbin Zhou <zhoubinbin@...ngson.cn>
> Cc: Huacai Chen <chenhuacai@...nel.org>
> Cc: WANG Xuerui <kernel@...0n.name>
> Cc: loongarch@...ts.linux.dev
> ---
> arch/loongarch/kernel/kgdb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/arch/loongarch/kernel/kgdb.c b/arch/loongarch/kernel/kgdb.c
> --- a/arch/loongarch/kernel/kgdb.c
> +++ b/arch/loongarch/kernel/kgdb.c
> @@ -13,6 +13,7 @@
> #include <linux/sched.h>
> #include <linux/smp.h>
>
> +#include <asm/cacheflush.h>
> #include <asm/fpu.h>
> #include <asm/lbt.h>
> #include <asm/hw_breakpoint.h>
Powered by blists - more mailing lists