[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0eed406a-c336-c948-18cb-d46e9992af06@linux.ibm.com>
Date: Tue, 29 Aug 2023 10:36:50 +0530
From: kajoljain <kjain@...ux.ibm.com>
To: Ian Rogers <irogers@...gle.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Kan Liang <kan.liang@...ux.intel.com>,
Ravi Bangoria <ravi.bangoria@....com>,
John Garry <john.g.garry@...cle.com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/2] perf list: Remove duplicate PMUs
Hi,
Patchset looks good to me.
Reviewed-by: Kajol Jain <kjain@...ux.ibm.com>
Thanks,
Kajol Jain
On 8/25/23 19:22, Ian Rogers wrote:
> When there are multiple PMUs, differing by ordered suffixes, by
> default only display one. This avoids repeated listing of events, in
> particular when there are 10s of uncore PMUs. If "-v" is passed to
> "perf list" then still list all PMUs.
>
> Listing fewer PMU/event combinations helps speed the all PMU event
> tests.
>
> Before:
> ```
> $ perf list
> ...
> uncore_imc_free_running_0/data_read/ [Kernel PMU event]
> uncore_imc_free_running_0/data_total/ [Kernel PMU event]
> uncore_imc_free_running_0/data_write/ [Kernel PMU event]
> uncore_imc_free_running_1/data_read/ [Kernel PMU event]
> uncore_imc_free_running_1/data_total/ [Kernel PMU event]
> uncore_imc_free_running_1/data_write/ [Kernel PMU event]
> ```
>
> After:
> ```
> $ perf list
> ...
> uncore_imc_free_running/data_read/ [Kernel PMU event]
> uncore_imc_free_running/data_total/ [Kernel PMU event]
> uncore_imc_free_running/data_write/ [Kernel PMU event]
> ...
> $ perf list -v
> ...
> uncore_imc_free_running_0/data_read/ [Kernel PMU event]
> uncore_imc_free_running_0/data_total/ [Kernel PMU event]
> uncore_imc_free_running_0/data_write/ [Kernel PMU event]
> uncore_imc_free_running_1/data_read/ [Kernel PMU event]
> uncore_imc_free_running_1/data_total/ [Kernel PMU event]
> uncore_imc_free_running_1/data_write/ [Kernel PMU event]
> ...
> ```
>
> The PMUs are sorted by name then suffix as a part of this change.
>
> v5: Improved the 2nd patch's commit message and removed an unused
> variable as suggested by Kan Liang <kan.liang@...ux.intel.com>.
> v4: Rebase on top of lazy PMU changes. Ignore numeric ordering due to
> gaps, suggested by Kan Liang <kan.liang@...ux.intel.com>. Fold
> patches 2 & 3 as suggested by John Garry <john.g.garry@...cle.com>
> (done by accident as part of rebasing).
> v3: Add detail to patch 1 sorting commit message about the suffix and
> why sorting is necessary.
> v2: List all PMUs when "-v" is passed as suggested by John Garry
> <john.g.garry@...cle.com>.
>
> Ian Rogers (2):
> perf pmus: Sort pmus by name then suffix
> perf pmus: Skip duplicate PMUs and don't print list suffix by default
>
> tools/perf/builtin-list.c | 8 +++
> tools/perf/util/pmu.c | 17 ++++--
> tools/perf/util/pmu.h | 3 +-
> tools/perf/util/pmus.c | 99 ++++++++++++++++++++++++++++++-
> tools/perf/util/pmus.h | 2 +
> tools/perf/util/print-events.h | 1 +
> tools/perf/util/s390-sample-raw.c | 3 +-
> 7 files changed, 123 insertions(+), 10 deletions(-)
>
Powered by blists - more mailing lists