linux-kernel - RE: linux-next: Tree for Aug 28 (drivers/platform/x86/mlx-platform.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN9PR12MB5381C39F394EA2E292A057BFAFE7A@BN9PR12MB5381.namprd12.prod.outlook.com>
Date:   Tue, 29 Aug 2023 05:39:18 +0000
From:   Vadim Pasternak <vadimp@...dia.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:X86 PLATFORM DRIVERS" 
        <platform-driver-x86@...r.kernel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        PCI <linux-pci@...r.kernel.org>
Subject: RE: linux-next: Tree for Aug 28 (drivers/platform/x86/mlx-platform.c)



> -----Original Message-----
> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Monday, 28 August 2023 23:36
> To: Stephen Rothwell <sfr@...b.auug.org.au>; Linux Next Mailing List <linux-
> next@...r.kernel.org>
> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; open list:X86
> PLATFORM DRIVERS <platform-driver-x86@...r.kernel.org>; Vadim Pasternak
> <vadimp@...dia.com>; Hans de Goede <hdegoede@...hat.com>; Mark
> Gross <markgross@...nel.org>; PCI <linux-pci@...r.kernel.org>
> Subject: Re: linux-next: Tree for Aug 28 (drivers/platform/x86/mlx-platform.c)
> 
> 
> 
> On 8/27/23 22:02, Stephen Rothwell wrote:
> > Hi all,
> >
> > Please do *not* include material destined for v6.7 in your linux-next
> > included branches until *after* v6.6-rc1 has been released.  Also, do
> > *not* rebase you linu-next included branches onto v6.5.
> >
> > Changes since 20230825:
> >
> 
> on i386:
> CONFIG_ACPI=y
> CONFIG_ISA=y
> # CONFIG_PCI is not set
> 
> ../drivers/platform/x86/mlx-platform.c: In function
> 'mlxplat_pci_fpga_device_init':
> ../drivers/platform/x86/mlx-platform.c:6204:15: error: implicit declaration of
> function 'pci_request_region'; did you mean 'pci_request_regions'? [-
> Werror=implicit-function-declaration]
>  6204 |         err = pci_request_region(pci_dev, 0, res_name);
>       |               ^~~~~~~~~~~~~~~~~~
>       |               pci_request_regions
> 
> Should MLX_PLATFORM depend on PCI?
> 
> or do we need a stub for pci_request_region()?

Thanks, Randy.

Need to add: 'depend on PCI'.

I will send a patch.

> 
> --
> ~Randy