linux-kernel - Re: [PATCH] cpufreq: Fix inconsistency in error messages of cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230829060129.ux7lbf22t225necx@vireshk-i7>
Date:   Tue, 29 Aug 2023 11:31:29 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     "Liao, Chang" <liaochang1@...wei.com>
Cc:     rafael@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: Fix inconsistency in error messages of
 cpufreq_resume/suspend()

On 28-08-23, 20:31, Liao, Chang wrote:
> What about printing message like this below when cpufreq_start_governor() fails.
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 50bbc969ffe5..b78b509429a6 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1943,16 +1943,16 @@ void cpufreq_resume(void)
> 
>                         if (ret)
> -                               pr_err("%s: Failed to start governor for policy: %p\n",
> -                                      __func__, policy);
> +                               pr_err("%s: Failed to start governor for policy%u\n",

s/policy/CPU%u's policy/ ?

> +                                      __func__, policy->cpu);

Sounds good.

-- 
viresh