linux-kernel - Re: [PATCH] mm: fix draining remote pageset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6oi4bzk.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date:   Tue, 29 Aug 2023 14:08:15 +0800
From:   "Huang, Ying" <ying.huang@...el.com>
To:     "Lameter, Christopher" <cl@...amperecomputing.com>
Cc:     Michal Hocko <mhocko@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH] mm: fix draining remote pageset

Hi, Christopher,

"Lameter, Christopher" <cl@...amperecomputing.com> writes:

> On Tue, 22 Aug 2023, Michal Hocko wrote:
>
>> Yes, this doesn't really show any actual correctness problem so I do not
>> think this is sufficient to change the code. You would need to show that
>> the existing behavior is actively harmful.
>
> Having some pages from a remote NUMA node stuck in a pcp somewhere is
> making that memory unusable. It is usually rate that these remote
> pages are needed again and so they may remain there for a long time if
> the situation is right.
>
> And he is right that the intended behavior of freeing the remote pages
> has been disabled by the patch.
>
> So I think there is sufficient rationale to apply these fixes.

Thanks!  Can I get your "Acked-by" or "Reviewed-by" for the patch?

--
Best Regards,
Huang, Ying