linux-kernel - Re: [PATCH v2] cpufreq: Avoid printing kernel addresses in cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Aug 2023 12:43:38 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Liao Chang <liaochang1@...wei.com>
Cc:     rafael@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cpufreq: Avoid printing kernel addresses in
 cpufreq_resume()

On 29-08-23, 07:01, Liao Chang wrote:
> The pointer value of policy and driver structure are currently printed
> in the error messages of cpufreq_resume(), this is not recommended and
> helpful. In order to be consistent with the error message in
> cpufreq_suspend() and easier to understand, print the name of driver
> strcture and the manage CPU of policy structure individually in the
> error messages of cpufreq_resume().
> 
> Link: https://lore.kernel.org/all/b7be717c-41d8-bbbf-3e97-3799948ab757@huawei.com
> Signed-off-by: Liao Chang <liaochang1@...wei.com>
> ---
>  drivers/cpufreq/cpufreq.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 50bbc969ffe5..26fa99d46684 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1943,16 +1943,16 @@ void cpufreq_resume(void)
>  
>  	for_each_active_policy(policy) {
>  		if (cpufreq_driver->resume && cpufreq_driver->resume(policy)) {
> -			pr_err("%s: Failed to resume driver: %p\n", __func__,
> -				policy);
> +			pr_err("%s: Failed to resume driver: %s\n", __func__,
> +				cpufreq_driver->name);
>  		} else if (has_target()) {
>  			down_write(&policy->rwsem);
>  			ret = cpufreq_start_governor(policy);
>  			up_write(&policy->rwsem);
>  
>  			if (ret)
> -				pr_err("%s: Failed to start governor for policy: %p\n",
> -				       __func__, policy);
> +				pr_err("%s: Failed to start governor for CPU%u's policy\n",
> +				       __func__, policy->cpu);
>  		}
>  	}
>  }

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh