linux-kernel - Re: [PATCH v4 2/2] iio: adc: adding support for MCP3564 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae3562ee30e6d8aecae2a447cffc4ad6e8e44578.camel@microchip.com>
Date:   Tue, 29 Aug 2023 07:29:57 +0000
From:   <Marius.Cristea@...rochip.com>
To:     <jic23@...nel.org>
CC:     <devicetree@...r.kernel.org>, <conor+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <lars@...afoo.de>,
        <linux-iio@...r.kernel.org>, <robh+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] iio: adc: adding support for MCP3564 ADC

Hi Jonathan,

   Thank you for the review.


> 
> 
> > +
> > +/*
> > + * Current Source/Sink Selection Bits for Sensor Bias (source on
> > VIN+/sink on VIN-)
> > + */
> > +static const int mcp3564_burnout_avail[][2] = {
> > +     [MCP3564_CONFIG0_CS_SEL_0_0_uA] = {0, 0},
> > +     [MCP3564_CONFIG0_CS_SEL_0_9_uA] = {0, 900},
> > +     [MCP3564_CONFIG0_CS_SEL_3_7_uA] = {0, 3700},
> > +     [MCP3564_CONFIG0_CS_SEL_15_uA] = {0, 15000}
> > +};
> 
> Trivial, but I'd like brackets after the { and before the } as makes
> things a tiny bit
> more readable to my eye.
> 
> 

I'm not sure that I understood what/how to change here. Can you,
please, give me an example?



Thanks,
Marius