linux-kernel - Re: [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcf2f600-d1f0-de14-956b-4d4f3f0cb3fa@leemhuis.info>
Date:   Tue, 29 Aug 2023 10:38:38 +0200
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@...mhuis.info>
To:     Mario Limonciello <mario.limonciello@....com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        Paul Menzel <pmenzel@...gen.mpg.de>
Cc:     linux-integrity@...r.kernel.org,
        Jerry Snitselaar <jsnitsel@...hat.com>, stable@...r.kernel.org,
        Todd Brandt <todd.e.brandt@...el.com>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-kernel@...r.kernel.org,
        Patrick Steinhardt <ps@....im>, Ronan Pigott <ronan@....ie>,
        Raymond Jay Golo <rjgolo@...il.com>,
        Linux kernel regressions list <regressions@...ts.linux.dev>,
        Dusty Mabe <dusty@...tymabe.com>
Subject: Re: [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs

[CCing the regression list, as it should be in the loop for regressions:
https://docs.kernel.org/admin-guide/reporting-regressions.html]

On 28.08.23 02:35, Mario Limonciello wrote:
> On 8/27/2023 13:12, Jarkko Sakkinen wrote:
>> On Wed Aug 23, 2023 at 9:58 PM EEST, Mario Limonciello wrote:
>>> On 8/23/2023 12:40, Jarkko Sakkinen wrote:
>>>> On Wed Aug 23, 2023 at 11:23 AM EEST, Paul Menzel wrote:
>>>>> Am 23.08.23 um 01:15 schrieb Jarkko Sakkinen:
>>>>>> The vendor check introduced by commit 554b841d4703 ("tpm: Disable
>>>>>> RNG for
>>>>>> all AMD fTPMs") doesn't work properly on a number of Intel fTPMs. 
>>>>>> On the
>>>>>> reported systems the TPM doesn't reply at bootup and returns back the
>>>>>> command code. This makes the TPM fail probe.
>>>>>>
>>>>>> Since only Microsoft Pluton is the only known combination of AMD
>>>>>> CPU and
>>>>>> fTPM from other vendor, disable hwrng otherwise. In order to make
>>>>>> sysadmin
>>>>>> aware of this, print also info message to the klog.
>>>>>>
>>>>>> Cc: stable@...r.kernel.org
>>>>>> Fixes: 554b841d4703 ("tpm: Disable RNG for all AMD fTPMs")
>>>>>> Reported-by: Todd Brandt <todd.e.brandt@...el.com>
>>>>>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217804
>>>>>> Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
>>>>>
>>>>> Mario’s patch also had the three reporters below listed:
>>>>>
>>>>> Reported-by: Patrick Steinhardt <ps@....im>
>>>>> Reported-by: Ronan Pigott <ronan@....ie>
>>>>> Reported-by: Raymond Jay Golo <rjgolo@...il.com>
>>>>
>>>> The problem here is that checkpatch throws three warnings:
>>>>
>>>> WARNING: Reported-by: should be immediately followed by Closes: with
>>>> a URL to the report

Note, those are warnings (and not an errors) on purpose and the text
says "should" (and not "must"), so this is IMHO something in this case
can be ignored, as Mario indicated in his reply.

But I write for a different reason: this seems to become a regression
that is annoying quite a few people (in 6.5 and 6.4.y afaics), so it
would be good to get the fix merged to mainline rather sooner than
later. Are these warnings and the mentioning of affected machines in the
patch descriptions the only remaining problems, or is there anything
else that needs to be addressed?

Ciao, Thorsten (just back from vacation and catching up)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke