linux-kernel - Re: [PATCH v4 1/2] gpio: dt-bindings: add more loongson gpio chip support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a6eb9a3d-83b2-c344-13bb-29a25937117f@loongson.cn>
Date:   Tue, 29 Aug 2023 20:12:40 +0800
From:   Yinbo Zhu <zhuyinbo@...ngson.cn>
To:     Conor Dooley <conor@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jianmin Lv <lvjianmin@...ngson.cn>, wanghongliang@...ngson.cn,
        loongson-kernel@...ts.loongnix.cn, zhuyinbo@...ngson.cn
Subject: Re: [PATCH v4 1/2] gpio: dt-bindings: add more loongson gpio chip
 support



在 2023/8/23 下午11:08, Conor Dooley 写道:
> On Wed, Aug 23, 2023 at 11:34:26AM +0800, Yinbo Zhu wrote:
>> This patch was to add loongson 2k0500, 2k2000 and 3a5000 gpio chip
>> dt-bindings support in yaml file.
>>
>> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
>> ---
>>   .../bindings/gpio/loongson,ls-gpio.yaml       | 23 +++++++++++++++----
>>   1 file changed, 19 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>> index fb86e8ce6349..97472f1529a0 100644
>> --- a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>> +++ b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
>> @@ -11,9 +11,24 @@ maintainers:
>>   
>>   properties:
>>     compatible:
>> -    enum:
>> -      - loongson,ls2k-gpio
>> -      - loongson,ls7a-gpio
>> +    oneOf:
>> +      - enum:
>> +          - loongson,ls2k-gpio
>> +          - loongson,ls2k0500-gpio0
>> +          - loongson,ls2k0500-gpio1
>> +          - loongson,ls2k2000-gpio0
>> +          - loongson,ls2k2000-gpio1
>> +          - loongson,ls2k2000-gpio2
>> +          - loongson,ls3a5000-gpio
>> +          - loongson,ls7a-gpio
> 
>> +      - items:
>> +          - enum:
>> +              - loongson,ls2k1000-gpio
>> +          - const: loongson,ls2k-gpio
>> +      - items:
>> +          - enum:
>> +              - loongson,ls7a1000-gpio
>> +          - const: loongson,ls7a-gpio
> 
> Are there going to be more controllers that are compatible with
> "ls7a-gpio"? If not, you can simplify both of these to have 2 const:
> entries, like:
> 
>        - items:
>            - const: loongson,ls2k1000-gpio
>            - const: loongson,ls2k-gpio
> 
>        - items:
>            - const: loongson,ls7a1000-gpio
>            - const: loongson,ls7a-gpio
> 
> Either way,
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>


okay, I got it.

Thanks,
Yinbo
>