linux-kernel - Re: [PATCH net-next 00/22] convert to devm_stmmac_probe_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Aug 2023 15:22:58 +0200
From:   Emil Renner Berthing <kernel@...il.dk>
To:     Jisheng Zhang <jszhang@...nel.org>
Cc:     "Russell King (Oracle)" <linux@...linux.org.uk>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Samin Guo <samin.guo@...rfivetech.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 00/22] convert to devm_stmmac_probe_config_dt

On Tue, 29 Aug 2023 at 13:41, Jisheng Zhang <jszhang@...nel.org> wrote:
>
> On Tue, Aug 29, 2023 at 12:21:29PM +0100, Russell King (Oracle) wrote:
> > On Tue, Aug 29, 2023 at 06:40:11PM +0800, Jisheng Zhang wrote:
> > > Russell pointed out there's a new devm_stmmac_probe_config_dt()
> > > helper now when reviewing my starfive gmac error handling patch[1].
> > > After greping the code, this nice helper was introduced by Bartosz in
> > > [2], I think it's time to convert all dwmac users to this helper and
> > > finally complete the TODO in [2] "but once all users of the old
> > > stmmac_pltfr_remove() are converted to the devres helper, it will be
> > > renamed back to stmmac_pltfr_remove() and the no_dt function removed."
> >
> > I think a useful final patch may be to make stmmac_probe_config_dt()
> > static so there aren't any new uses of stmmac_probe_config_dt().
>
> Good idea!

Once this is done are there any users of stmmac_pltfr_remove() left?
If not it would be great to remove that too and maybe even remove the
_no_dt from stmmac_pltfr_remove_no_dt().

> >
> > Also note that net-next is now closed, so please wait until after -rc1
> > for net-next to re-open, or post as RFC. Thanks.
>
> oops, I didn't notice this cycle of window is closed, I will wait for next
> development window.
>
> Thank you
> >
> > --
> > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!