linux-kernel - Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZO3xlJ/7WDCDuz2T@smile.fi.intel.com>
Date:   Tue, 29 Aug 2023 16:24:36 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Sergey Ryazanov <ryazanov.s.a@...il.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        haozhe chang <haozhe.chang@...iatek.com>,
        Loic Poulain <loic.poulain@...aro.org>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to
 allocate bitmaps

On Mon, Aug 28, 2023 at 09:06:09PM +0300, Sergey Ryazanov wrote:
> On 28.08.2023 16:19, Andy Shevchenko wrote:
> > Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> > It is less verbose and it improves the type checking and semantic.
> > 
> > While at it, add missing header inclusion (should be bitops.h,
> > but with the above change it becomes bitmap.h).
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Make sense. Thank you.
> 
> BTW, any plans to update __dev_alloc_name(), which was used as reference, in
> the same way?

Ah, will look at it, thanks for the pointer.

> Reviewed-by: Sergey Ryazanov <ryazanov.s.a@...il.com>

And thank you for the review!

-- 
With Best Regards,
Andy Shevchenko