[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3fd2e62d-0aa9-1098-3eb3-ed45460a3580@intel.com>
Date: Tue, 29 Aug 2023 15:56:41 +0200
From: "Wilczynski, Michal" <michal.wilczynski@...el.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
Guenter Roeck <linux@...ck-us.net>
CC: <andriy.shevchenko@...el.com>, <artem.bityutskiy@...ux.intel.com>,
<mingo@...hat.com>, <bp@...en8.de>, <dave.hansen@...ux.intel.com>,
<hpa@...or.com>, <lenb@...nel.org>, <jgross@...e.com>,
<linux-kernel@...r.kernel.org>, <x86@...nel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH] ACPI: processor: Move MWAIT quirk out of acpi_processor.c
On 8/29/2023 3:54 PM, Rafael J. Wysocki wrote:
> On Tue, Aug 29, 2023 at 3:44 PM Guenter Roeck <linux@...ck-us.net> wrote:
>> On Mon, Jul 10, 2023 at 05:03:29PM +0300, Michal Wilczynski wrote:
>>> Commit 2a2a64714d9c ("ACPI: Disable MWAIT via DMI on broken Compal board")
>>> introduced a workaround for MWAIT for a specific x86 system.
>>>
>>> Move the code outside of acpi_processor.c to acpi/x86/ directory for
>>> consistency and rename the functions associated with it, so their names
>>> start with "acpi_proc_quirk_" to make the goal obvious.
>>>
>>> No intentional functional impact.
>>>
>> Except for:
>>
>> ia64-linux-ld: drivers/acpi/acpi_processor.o: in function `acpi_early_processor_control_setup':
>> acpi_processor.c:(.init.text+0x712): undefined reference to `acpi_proc_quirk_mwait_check'
>> ia64-linux-ld: drivers/acpi/processor_pdc.o: in function `acpi_early_processor_set_pdc':
>> processor_pdc.c:(.init.text+0x72): undefined reference to `acpi_proc_quirk_mwait_check'
>>
>> which breaks all ia64 builds.
>>
>> Time to retire that architecture yet ? No one but me seems to even
>> build test it.
> Including 0-day it seems. This had been in linux-next for several weeks.
>
> Michal, can you have a look at this please?
Hi,
I'll take a look and get back to you with a fix,
Regards,
Michał
Powered by blists - more mailing lists