linux-kernel - Re: [PATCH v4 1/1] rtc: nuvoton: Compatible with NCT3015Y-R and NCT3018Y-R

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2023082914221048e46085@mail.local>
Date:   Tue, 29 Aug 2023 16:22:10 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Minying Lin <mimi05633@...il.com>
Cc:     "avifishman70@...il.com" <avifishman70@...il.com>,
        "tmaimon77@...il.com" <tmaimon77@...il.com>,
        "tali.perry1@...il.com" <tali.perry1@...il.com>,
        "venture@...gle.com" <venture@...gle.com>,
        "yuenn@...gle.com" <yuenn@...gle.com>,
        "benjaminfair@...gle.com" <benjaminfair@...gle.com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "KWLIU@...oton.com" <KWLIU@...oton.com>,
        "JJLIU0@...oton.com" <JJLIU0@...oton.com>,
        "KFLIN@...oton.com" <KFLIN@...oton.com>,
        "mylin1@...oton.com" <mylin1@...oton.com>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/1] rtc: nuvoton: Compatible with NCT3015Y-R and
 NCT3018Y-R

On 29/08/2023 21:35:36+0800, Minying Lin wrote:
> > Do you really have to check the part number every time you set the time?
> > I don't expect it to change once read in probe.
> >
> [Mia] Due to the 3018Y's topology, we need to set the TWO bit first to
> obtain the write time capability, but the 3015Y does not have this problem.
> Therefore, we use part number & TWO bit to determine whether we need to set
> the TWO bit first before set time.
> 

Sure but why don't you store the info somewhere instead of reading it
from the RTC every time?

> >
> > > +     if (part_num < 0) {
> > > +             dev_dbg(&client->dev, "%s: Failed to read part info
> > reg.\n", __func__);
> > > +             return part_num;
> > > +     }
> > > +
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> >

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com