linux-kernel - Re: [PATCH v2 2/2] mfd: palmas: Make similar OF and ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZO4EwAgDU0yefC/t@smile.fi.intel.com>
Date:   Tue, 29 Aug 2023 17:46:24 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     Tony Lindgren <tony@...mide.com>, Lee Jones <lee@...nel.org>,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] mfd: palmas: Make similar OF and ID table

On Mon, Aug 28, 2023 at 04:31:44PM +0100, Biju Das wrote:
> Make similar OF and ID table to extend support for ID match using
> i2c_match_data(). Currently it works only for OF match tables as the
> driver_data is wrong for ID match.

...

> While at it, drop the inner leading commas for ID  table.

Are you sure?

------------------v
> -	{ "palmas", },
> -	{ "twl6035", },
> -	{ "twl6037", },
> -	{ "tps65913", },
> +	{ "palmas", (kernel_ulong_t)&palmas_data },
> +	{ "twl6035", (kernel_ulong_t)&palmas_data },
> +	{ "twl6037", (kernel_ulong_t)&palmas_data },
> +	{ "tps65913", (kernel_ulong_t)&palmas_data },

-- 
With Best Regards,
Andy Shevchenko