linux-kernel - RE: [PATCH v2] mfd: max77541: Simplify probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB5922AE1C328FD2485C4D83BB86E7A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Tue, 29 Aug 2023 14:58:20 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     Lee Jones <lee@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] mfd: max77541: Simplify probe()

Hi Andy Shevchenko,

> Subject: Re: [PATCH v2] mfd: max77541: Simplify probe()
> 
> On Mon, Aug 28, 2023 at 04:38:05PM +0100, Biju Das wrote:
> > Simplify probe() by replacing device_get_match_data() and ID lookup
> > for retrieving match data by i2c_get_match_data().
> 
> ...
> 
> > While at it, drop leading commas from OF table.
> 
> Sure?
> 
> ...
> 
> >  static const struct of_device_id max77541_of_id[] = {
> > -	{
> > -		.compatible = "adi,max77540",
> > -		.data = (void *)MAX77540,
> > -	},
> > -	{
> > -		.compatible = "adi,max77541",
> > -		.data = (void *)MAX77541,
> > -	},
> > +	{ .compatible = "adi,max77540", .data = (void *)MAX77540 },
> > +	{ .compatible = "adi,max77541", .data = (void *)MAX77541 },
> >  	{ }
> >  };
> 
> Seems to me an unneeded churn as nothing has been changed here (except
> commas and indentation). If any, it should be a separate change.

See there is a comma after every .data, that is leading commas right?

Cheers,
Biju