[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230829-juror-decathlon-f7b252a330bf@spud>
Date: Tue, 29 Aug 2023 16:00:06 +0100
From: Conor Dooley <conor@...nel.org>
To: Alain Volmat <alain.volmat@...s.st.com>
Cc: Hugues Fruchet <hugues.fruchet@...s.st.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Dan Scally <dan.scally@...asonboard.com>,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: media: add bindings for dcmipp driver
Hey,
On Tue, Aug 29, 2023 at 03:23:45PM +0200, Alain Volmat wrote:
> Add the yaml binding for the DCMIPP driver.
Please drop all mentions of drivers, bindings are for hardware.
>
> Signed-off-by: Alain Volmat <alain.volmat@...s.st.com>
> ---
> .../bindings/media/st,stm32-dcmipp.yaml | 95 +++++++++++++++++++
> 1 file changed, 95 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml
> new file mode 100644
> index 000000000000..63f03a1c42b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmipp.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/st,stm32-dcmipp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32 DCMIPP Digital Camera Memory Interface Pixel Processor binding
s/binding// to appease the bot.
> +
> +maintainers:
> + - Hugues Fruchet <hugues.fruchet@...s.st.com>
> + - Alain Volmat <alain.volmat@...s.st.com>
> +
> +properties:
> + compatible:
> + const: st,stm32mp13-dcmipp
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: kclk
Can drop the items: here since you only have one. The name is also
pretty pointless when you only have one...
> +
> + resets:
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description:
> + DCMIPP supports a single port node with parallel bus.
> +
> + properties:
> + endpoint:
> + $ref: video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + bus-type:
> + enum: [5, 6]
> + default: 5
> +
> + bus-width:
> + enum: [8, 10, 12, 14]
> + default: 8
> +
> + pclk-sample: true
> + hsync-active: true
> + vsync-active: true
> +
> + required:
> + - pclk-sample
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - resets
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/stm32mp13-clks.h>
> + #include <dt-bindings/reset/stm32mp13-resets.h>
> + dcmipp: dcmipp@...00000 {
Neither of the labels here are used AFAICT, please remove them.
Thanks,
Conor.
> + compatible = "st,stm32mp13-dcmipp";
> + reg = <0x5a000000 0x400>;
> + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&rcc DCMIPP_R>;
> + clocks = <&rcc DCMIPP_K>;
> + clock-names = "kclk";
> +
> + port {
> + dcmipp_0: endpoint {
> + remote-endpoint = <&mipid02_2>;
> + bus-width = <8>;
> + hsync-active = <0>;
> + vsync-active = <0>;
> + pclk-sample = <0>;
> + };
> + };
> + };
> +
> +...
> --
> 2.25.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists