linux-kernel - Re: [PATCH v2 1/2] regulator: pv880x0: Simplify probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZO4KqF+gnJDlWvRB@smile.fi.intel.com>
Date:   Tue, 29 Aug 2023 18:11:36 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] regulator: pv880x0: Simplify probe()

On Mon, Aug 28, 2023 at 06:24:16PM +0100, Biju Das wrote:
> Replace pv88080_types->pv88080_compatible_regmap in OF/ID tables and
> simplify the probe() by replacing of_match_node() and ID lookup for
> retrieving match data by i2c_get_match_data(). After this there is
> no user of enum pv88080_types. So drop it.
> 
> While at it, remove trailing comma in the terminator entry for OF/ID
> tables.

...

> +#ifdef CONFIG_OF

Do you still need this? (Perhaps in a separate patch to remove?)

...

> +static const struct of_device_id pv88080_dt_ids[] = {
> +	{ .compatible = "pvs,pv88080",    .data = &pv88080_aa_regs },
> +	{ .compatible = "pvs,pv88080-aa", .data = &pv88080_aa_regs  },

One space too many.

> +	{ .compatible = "pvs,pv88080-ba", .data = &pv88080_ba_regs },
> +	{}
> +};

-- 
With Best Regards,
Andy Shevchenko