linux-kernel - Re: [PATCH] tick/nohz: remove unused tick_nohz_idle_stop_tick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZO4YlOWJS8sb62cS@lothringen>
Date:   Tue, 29 Aug 2023 18:11:00 +0200
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Xueshi Hu <xueshi.hu@...rtx.com>
Cc:     tglx@...utronix.de, mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tick/nohz: remove unused
 tick_nohz_idle_stop_tick_protected()

On Sun, Aug 13, 2023 at 09:11:53PM +0800, Xueshi Hu wrote:
> All the caller has been removed since commit 336f560a8917 ("x86/xen: don't
> let xen_pv_play_dead() return")
> 
> Signed-off-by: Xueshi Hu <xueshi.hu@...rtx.com>

Applied to my pending queue, thanks!

> ---
>  include/linux/tick.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/include/linux/tick.h b/include/linux/tick.h
> index 9459fef5b857..716d17f31c45 100644
> --- a/include/linux/tick.h
> +++ b/include/linux/tick.h
> @@ -140,14 +140,6 @@ extern unsigned long tick_nohz_get_idle_calls(void);
>  extern unsigned long tick_nohz_get_idle_calls_cpu(int cpu);
>  extern u64 get_cpu_idle_time_us(int cpu, u64 *last_update_time);
>  extern u64 get_cpu_iowait_time_us(int cpu, u64 *last_update_time);
> -
> -static inline void tick_nohz_idle_stop_tick_protected(void)
> -{
> -	local_irq_disable();
> -	tick_nohz_idle_stop_tick();
> -	local_irq_enable();
> -}
> -
>  #else /* !CONFIG_NO_HZ_COMMON */
>  #define tick_nohz_enabled (0)
>  static inline int tick_nohz_tick_stopped(void) { return 0; }
> @@ -170,8 +162,6 @@ static inline ktime_t tick_nohz_get_sleep_length(ktime_t *delta_next)
>  }
>  static inline u64 get_cpu_idle_time_us(int cpu, u64 *unused) { return -1; }
>  static inline u64 get_cpu_iowait_time_us(int cpu, u64 *unused) { return -1; }
> -
> -static inline void tick_nohz_idle_stop_tick_protected(void) { }
>  #endif /* !CONFIG_NO_HZ_COMMON */
>  
>  #ifdef CONFIG_NO_HZ_FULL
> -- 
> 2.40.1
>