linux-kernel - Re: [PATCH v3] MIPS: loongson32: Remove dma.h and nand.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34466e53-9cab-4094-7a9e-ae1f65385194@linaro.org>
Date:   Wed, 30 Aug 2023 23:11:23 +0200
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     Keguang Zhang <keguang.zhang@...il.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [PATCH v3] MIPS: loongson32: Remove dma.h and nand.h

On 30/8/23 15:35, Keguang Zhang wrote:
> Since commit 7b3415f581c7 ("MIPS: Loongson32: Remove
> unused platform devices"), struct plat_ls1x_dma and plat_ls1x_nand
> are unused. Then, dma.h and nand.h are useless.
> Therefore, remove these useless header files.
> 
> Signed-off-by: Keguang Zhang <keguang.zhang@...il.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>
> ---
> V2 -> V3: Fix the build error
>            Add Reviewed-by tag from Philippe Mathieu-Daudé
> V1 -> V2: Remove include of dma.h and nand.h
>            Update the commit message
> ---
>   arch/mips/include/asm/mach-loongson32/dma.h   | 21 ---------------
>   arch/mips/include/asm/mach-loongson32/nand.h  | 26 -------------------
>   .../include/asm/mach-loongson32/platform.h    |  3 ---
>   arch/mips/loongson32/common/platform.c        |  2 --
>   arch/mips/loongson32/ls1b/board.c             |  2 --
>   5 files changed, 54 deletions(-)
>   delete mode 100644 arch/mips/include/asm/mach-loongson32/dma.h
>   delete mode 100644 arch/mips/include/asm/mach-loongson32/nand.h


> diff --git a/arch/mips/include/asm/mach-loongson32/platform.h b/arch/mips/include/asm/mach-loongson32/platform.h
> index 2cdcfb5f6012..f74292b13bc3 100644
> --- a/arch/mips/include/asm/mach-loongson32/platform.h
> +++ b/arch/mips/include/asm/mach-loongson32/platform.h
> @@ -8,9 +8,6 @@
>   
>   #include <linux/platform_device.h>
>   
> -#include <dma.h>
> -#include <nand.h>

Doh I missed that one in v2 :/

Thanks, R-b stands.