linux-kernel - Re: [PATCH] mm/mmap: Define DEFAULT_STACK_GUARD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZO62hWK7r1zc1xsg@casper.infradead.org>
Date:   Wed, 30 Aug 2023 04:24:53 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/mmap: Define DEFAULT_STACK_GUARD_GAP

On Wed, Aug 30, 2023 at 08:25:45AM +0530, Anshuman Khandual wrote:
> 
> 
> On 8/29/23 18:02, Matthew Wilcox wrote:
> > On Mon, Aug 28, 2023 at 09:22:48AM +0530, Anshuman Khandual wrote:
> >> This just defines a macro constant i.e DEFAULT_STACK_GUARD_GAP representing
> >> the default gap, guarding the stack mapping. This does not cause functional
> >> changes.
> > 
> > But why have you done it at all?
> 
> Just as a normal cleanup which also improves readability.

hard disagree.  NAK this patch.