[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2b26d9e6-262c-0cd5-d390-e3b52f55e760@infradead.org>
Date: Tue, 29 Aug 2023 22:06:16 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: linux-kernel@...r.kernel.org
Cc: David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
dri-devel@...ts.freedesktop.org,
Harry Wentland <harry.wentland@....com>,
Alex Deucher <alexander.deucher@....com>,
amd-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] drm/connector: mark enum counter value as private
Hi,
On 7/15/23 17:46, Randy Dunlap wrote:
> Mark the DRM_MODE_COLORIMETRY_COUNT enum value as private in
> kernel-doc to prevent a build warning:
>
> include/drm/drm_connector.h:527: warning: Enum value 'DRM_MODE_COLORIMETRY_COUNT' not described in enum 'drm_colorspace'
>
> Fixes: c627087cb164 ("drm/connector: Use common colorspace_names array")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> Cc: Maxime Ripard <mripard@...nel.org>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: amd-gfx@...ts.freedesktop.org
> ---
> include/drm/drm_connector.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20230714.orig/include/drm/drm_connector.h
> +++ linux-next-20230714/include/drm/drm_connector.h
> @@ -522,7 +522,7 @@ enum drm_colorspace {
> DRM_MODE_COLORIMETRY_RGB_WIDE_FIXED = 13,
> DRM_MODE_COLORIMETRY_RGB_WIDE_FLOAT = 14,
> DRM_MODE_COLORIMETRY_BT601_YCC = 15,
> - /* not a valid value; merely used for counting */
> + /* private: not a valid value; merely used for counting */
> DRM_MODE_COLORIMETRY_COUNT
> };
>
Any comments on this patch?
The warning is still present in mainline.
The "private:" marker tells kernel-doc not to expect documentation for it.
thanks.
--
~Randy
Powered by blists - more mailing lists