[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <169341938045.463502.9445399366399743283.robh@kernel.org>
Date: Wed, 30 Aug 2023 13:16:21 -0500
From: Rob Herring <robh@...nel.org>
To: Tanmay Shah <tanmay.shah@....com>
Cc: Ben Levinsky <ben.levinsky@....com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
Mathieu Poirier <mathieu.poirier@...aro.org>,
linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
Michal Simek <michal.simek@....com>,
Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
Bjorn Andersson <andersson@...nel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: remoteproc: add Tightly Coupled
Memory (TCM) bindings
On Tue, 29 Aug 2023 11:18:58 -0700, Tanmay Shah wrote:
> From: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
>
> Introduce bindings for TCM memory address space on AMD-xilinx Zynq
> UltraScale+ platform. It will help in defining TCM in device-tree
> and make it's access platform agnostic and data-driven.
>
> Tightly-coupled memories(TCMs) are low-latency memory that provides
> predictable instruction execution and predictable data load/store
> timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memory
> banks on the ATCM and BTCM ports, for a total of 128 KB of memory.
>
> The TCM resources(reg, reg-names and power-domain) are documented for
> each TCM in the R5 node. The reg and reg-names are made as required
> properties as we don't want to hardcode TCM addresses for future
> platforms and for zu+ legacy implementation will ensure that the
> old dts w/o reg/reg-names works and stable ABI is maintained.
>
> It also extends the examples for TCM split and lockstep modes.
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
> Signed-off-by: Tanmay Shah <tanmay.shah@....com>
> ---
>
> Changes in v4:
> - Use address-cells and size-cells value 2
> - Modify ranges property as per new value of address-cells
> and size-cells
> - Modify child node "reg" property accordingly
> - Remove previous ack for further review
>
>
> .../remoteproc/xlnx,zynqmp-r5fss.yaml | 131 +++++++++++++++---
> 1 file changed, 113 insertions(+), 18 deletions(-)
>
Acked-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists