linux-kernel - Re: [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230830-procedure-frostbite-56c751f7c276@wendy>
Date:   Wed, 30 Aug 2023 09:34:06 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     William Qiu <william.qiu@...rfivetech.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>, <linux-mmc@...r.kernel.org>,
        Emil Renner Berthing <kernel@...il.dk>,
        Rob Herring <robh+dt@...nel.org>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>
Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties

On Wed, Aug 30, 2023 at 09:29:20AM +0200, Krzysztof Kozlowski wrote:
> On 30/08/2023 08:50, Conor Dooley wrote:
> > On Wed, Aug 30, 2023 at 11:18:44AM +0800, William Qiu wrote:
> >> Due to the change of tuning implementation, it's no longer necessary to
> >> use the "starfive,sysreg" property in dts, so drop the relevant
> >> description in dt-bindings here.
> > 
> > How does changing your software implantation invalidate a description of
> > the hardware?
> > 
> 
> Which is kind of proof that this syscon was just to substitute
> incomplete hardware description (e.g. missing clocks and phys). We
> should have rejected it. Just like we should reject them in the future.

:s I dunno what to do with this... I'm inclined to say not to remove it
from the binding or dts at all & only change the software.

> There are just few cases where syscon is reasonable. All others is just
> laziness. It's not only starfivetech, of course. Several other
> contributors do the same.

I'm not sure if laziness is fair, lack of understanding is usually more
likely.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)