linux-kernel - RE: [PATCH v4 09/10] iommu: Make iommu_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276F7754FB54A9B85A028238CE6A@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Wed, 30 Aug 2023 07:34:49 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Baolu Lu <baolu.lu@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>,
        "Will Deacon" <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        Jean-Philippe Brucker <jean-philippe@...aro.org>,
        Nicolin Chen <nicolinc@...dia.com>
CC:     "Liu, Yi L" <yi.l.liu@...el.com>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 09/10] iommu: Make iommu_queue_iopf() more generic

> From: Baolu Lu <baolu.lu@...ux.intel.com>
> Sent: Saturday, August 26, 2023 3:32 PM
> 
> On 8/25/23 4:17 PM, Tian, Kevin wrote:
> >> From: Lu Baolu <baolu.lu@...ux.intel.com>
> >> Sent: Friday, August 25, 2023 10:30 AM
> >>
> >> +int iommu_sva_handle_iopf(struct iopf_group *group)
> >> +{
> >> +	struct iommu_fault_param *fault_param = group->dev->iommu-
> >>> fault_param;
> >> +
> >> +	INIT_WORK(&group->work, iopf_handler);
> >> +	if (!queue_work(fault_param->queue->wq, &group->work))
> >> +		return -EBUSY;
> >> +
> >> +	return 0;
> >> +}
> >
> > this function is generic so the name should not tie to 'sva'.
> 
> Currently only sva uses it. It's fine to make it generic later when any
> new use comes. Does it work to you?
> 

It's fine given you moved this function to sva.c in next patch.