linux-kernel - Re: [PATCH] macintosh/ams: linux/platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7630bbd0-3296-be21-df90-bb12477b6893@infradead.org>
Date:   Wed, 30 Aug 2023 08:32:27 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Rob Herring <robh@...nel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] macintosh/ams: linux/platform_device.h is needed

Hi,

On 8/29/23 22:46, Christophe Leroy wrote:
> 
> 
> Le 30/08/2023 à 00:58, Randy Dunlap a écrit :
>> ams.h uses struct platform_device, so the header should be used
>> to prevent build errors:
>>
>> drivers/macintosh/ams/ams-input.c: In function 'ams_input_enable':
>> drivers/macintosh/ams/ams-input.c:68:45: error: invalid use of undefined type 'struct platform_device'
>>     68 |         input->dev.parent = &ams_info.of_dev->dev;
>> drivers/macintosh/ams/ams-input.c: In function 'ams_input_init':
>> drivers/macintosh/ams/ams-input.c:146:51: error: invalid use of undefined type 'struct platform_device'
>>    146 |         return device_create_file(&ams_info.of_dev->dev, &dev_attr_joystick);
>> drivers/macintosh/ams/ams-input.c: In function 'ams_input_exit':
>> drivers/macintosh/ams/ams-input.c:151:44: error: invalid use of undefined type 'struct platform_device'
>>    151 |         device_remove_file(&ams_info.of_dev->dev, &dev_attr_joystick);
>> drivers/macintosh/ams/ams-input.c: In function 'ams_input_init':
>> drivers/macintosh/ams/ams-input.c:147:1: error: control reaches end of non-void function [-Werror=return-type]
>>    147 | }
>>
>> Fixes: 233d687d1b78 ("macintosh: Explicitly include correct DT includes")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Rob Herring <robh@...nel.org>
>> Cc: linuxppc-dev@...ts.ozlabs.org
>> Cc: Michael Ellerman <mpe@...erman.id.au>
>> ---
>>   drivers/macintosh/ams/ams.h |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff -- a/drivers/macintosh/ams/ams.h b/drivers/macintosh/ams/ams.h
>> --- a/drivers/macintosh/ams/ams.h
>> +++ b/drivers/macintosh/ams/ams.h
>> @@ -6,6 +6,7 @@
>>   #include <linux/input.h>
>>   #include <linux/kthread.h>
>>   #include <linux/mutex.h>
>> +#include <linux/platform_device.h>
> 
> You modify ams.h to fix a problem in ams-input.c
> Is that correct ?
> 

struct platform_device is used in ams.h so I think the change
needs to be there.

> Shouldn't the include be in ams-input.c instead ?
> 
>>   #include <linux/spinlock.h>
>>   #include <linux/types.h>
>>   
> 
> Christophe

-- 
~Randy