linux-kernel - Re: [PATCH 3/6] selftests/openat2: Fix wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5f8dad8-51f-be61-79bb-c2747d192a@linux.intel.com>
Date:   Wed, 30 Aug 2023 15:25:09 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     "Wieczor-Retman, Maciej" <maciej.wieczor-retman@...el.com>
cc:     Shuah Khan <shuah@...nel.org>,
        Reinette Chatre <reinette.chatre@...el.com>,
        "Wieczor-Retman, Maciej" <maciej.wieczor-retman@...el.com>,
        Wieczor-Retman@...ux.intel.com, linux-kselftest@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] selftests/openat2: Fix wrong format specifier

On Mon, 28 Aug 2023, Wieczor-Retman, Maciej wrote:

> Ksft_print_msg() inside test_openat2_flags() uses the wrong format
> specifier for printing test.how->flags variable.
> 
> Change the format specifier to %llX so it matches the printed variable.
> 
> Signed-off-by: Wieczor-Retman, Maciej <maciej.wieczor-retman@...el.com>
> ---
>  tools/testing/selftests/openat2/openat2_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/openat2/openat2_test.c b/tools/testing/selftests/openat2/openat2_test.c
> index 7fb902099de4..9024754530b2 100644
> --- a/tools/testing/selftests/openat2/openat2_test.c
> +++ b/tools/testing/selftests/openat2/openat2_test.c
> @@ -300,7 +300,7 @@ void test_openat2_flags(void)
>  
>  			ksft_print_msg("openat2 unexpectedly returned ");
>  			if (fdpath)
> -				ksft_print_msg("%d['%s'] with %X (!= %X)\n",
> +				ksft_print_msg("%d['%s'] with %X (!= %llX)\n",
>  					       fd, fdpath, fdflags,
>  					       test->how.flags);
>  			else
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.