[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f91439b8-4740-c535-e21e-211cff3117ed@huaweicloud.com>
Date: Wed, 30 Aug 2023 15:07:39 +0800
From: Kemeng Shi <shikemeng@...weicloud.com>
To: Mel Gorman <mgorman@...hsingularity.net>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
akpm@...ux-foundation.org, baolin.wang@...ux.alibaba.com,
david@...hat.com, willy@...radead.org
Subject: Re: [PATCH v2 5/7] mm/compaction: remove repeat
compact_blockskip_flush check in reset_isolation_suitable
on 8/29/2023 11:05 PM, Mel Gorman wrote:
> On Sat, Aug 26, 2023 at 11:36:15PM +0800, Kemeng Shi wrote:
>> We have compact_blockskip_flush check in __reset_isolation_suitable, just
>> remove repeat check before __reset_isolation_suitable in
>> compact_blockskip_flush.
>>
>> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
>> Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
>
> The comment should move to __reset_isolation_suitable but otherwise
>
Thanks for the review, I will move comment in next version.
> Acked-by: Mel Gorman <mgorman@...hsingularity.net>
>
> As a complete aside, the reset_isolation_suitable and
> __reset_isolation_suitable were badly named because locking is not
> involved but it's meaningless churn to fix it.
>
Powered by blists - more mailing lists