linux-kernel - Re: mainline build failure due to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ledsfttf.wl-tiwai@suse.de>
Date:   Wed, 30 Aug 2023 17:12:12 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@...il.com>,
        James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        "Richard Fitzgerald" <rf@...nsource.cirrus.com>,
        Lee Jones <lee@...nel.org>, <alsa-devel@...a-project.org>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        <regressions@...ts.linux.dev>
Subject: Re: mainline build failure due to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")

On Wed, 30 Aug 2023 17:00:37 +0200,
Charles Keepax wrote:
> 
> On Wed, Aug 30, 2023 at 03:09:13PM +0200, Takashi Iwai wrote:
> > On Wed, 30 Aug 2023 13:29:57 +0200,
> > Sudip Mukherjee (Codethink) wrote:
> > > 
> > > Hi All,
> > > 
> > > The latest mainline kernel branch fails to build alpha, csky and s390
> > > allmodconfig with the error:
> > > 
> > > drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but not used [-Werror=unused-function]
> > >  1138 | static int cs42l43_runtime_resume(struct device *dev)
> > >       |            ^~~~~~~~~~~~~~~~~~~~~~
> > > drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but not used [-Werror=unused-function]
> > >  1124 | static int cs42l43_runtime_suspend(struct device *dev)
> > >       |            ^~~~~~~~~~~~~~~~~~~~~~~
> > > drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used [-Werror=unused-function]
> > >  1106 | static int cs42l43_resume(struct device *dev)
> > >       |            ^~~~~~~~~~~~~~
> > > drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not used [-Werror=unused-function]
> > >  1076 | static int cs42l43_suspend(struct device *dev)
> > >       |            ^~~~~~~~~~~~~~~
> > > 
> > > git bisect pointed to ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> > > 
> > > I will be happy to test any patch or provide any extra log if needed.
> > 
> > Adding __maybe_unused for those PM functions should work around it,
> > something like below.  Could you check it?
> > If it's confirmed to work, I'll submit properly.
> > 
> > 
> 
> This is probably the correct fix:
> 
> https://lore.kernel.org/lkml/20230822114914.340359-1-ckeepax@opensource.cirrus.com/
> 
> Just waiting on it to be reviewed.

Thanks, that looks better.  Let's wait for the patch acceptance.


Takashi