linux-kernel - Re: [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230830-commence-trickery-40eaa193cb15@wendy>
Date:   Wed, 30 Aug 2023 07:50:37 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     William Qiu <william.qiu@...rfivetech.com>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>, <linux-mmc@...r.kernel.org>,
        Emil Renner Berthing <kernel@...il.dk>,
        Rob Herring <robh+dt@...nel.org>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>
Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties

On Wed, Aug 30, 2023 at 11:18:44AM +0800, William Qiu wrote:
> Due to the change of tuning implementation, it's no longer necessary to
> use the "starfive,sysreg" property in dts, so drop the relevant
> description in dt-bindings here.

How does changing your software implantation invalidate a description of
the hardware?

> 
> Signed-off-by: William Qiu <william.qiu@...rfivetech.com>
> ---
>  .../bindings/mmc/starfive,jh7110-mmc.yaml         | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> index 51e1b04e799f..10df41941331 100644
> --- a/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> @@ -36,26 +36,12 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> -  starfive,sysreg:
> -    $ref: /schemas/types.yaml#/definitions/phandle-array
> -    items:
> -      - items:
> -          - description: phandle to System Register Controller syscon node
> -          - description: offset of SYS_SYSCONSAIF__SYSCFG register for MMC controller
> -          - description: shift of SYS_SYSCONSAIF__SYSCFG register for MMC controller
> -          - description: mask of SYS_SYSCONSAIF__SYSCFG register for MMC controller
> -    description:
> -      Should be four parameters, the phandle to System Register Controller
> -      syscon node and the offset/shift/mask of SYS_SYSCONSAIF__SYSCFG register
> -      for MMC controller.
> -
>  required:
>    - compatible
>    - reg
>    - clocks
>    - clock-names
>    - interrupts
> -  - starfive,sysreg
>  
>  unevaluatedProperties: false
>  
> @@ -73,5 +59,4 @@ examples:
>          fifo-depth = <32>;
>          fifo-watermark-aligned;
>          data-addr = <0>;
> -        starfive,sysreg = <&sys_syscon 0x14 0x1a 0x7c000000>;
>      };
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)