linux-kernel - Re: [PATCH v4] usb: typec: qcom: Update the logic of regulator enable and disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c477c29c-74db-9d48-0b45-b22b70dc93c0@roeck-us.net>
Date:   Wed, 30 Aug 2023 01:33:57 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     hui liu <quic_huliu@...cinc.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_fenglinw@...cinc.com,
        subbaram@...cinc.com
Subject: Re: [PATCH v4] usb: typec: qcom: Update the logic of regulator enable
 and disable

On 8/29/23 23:37, hui liu wrote:
> 
> 
> On 8/30/2023 2:25 PM, Guenter Roeck wrote:
>> On 8/29/23 20:00, Hui Liu via B4 Relay wrote:
>>> From: Hui Liu <quic_huliu@...cinc.com>
>>>
>>> Removed the call logic of disable and enable regulator
>>> in reset function. Enable the regulator in qcom_pmic_typec_start
>>> function and disable it in qcom_pmic_typec_stop function to
>>> avoid unbalanced regulator disable warnings.
>>>
>>> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
>>
>> Please drop.
> I didn't get your mean. would you please explain it?

You kept my Reviewed-by: tag even though the current version
of the patch is completely different to the patch I reviewed.
This is inappropriate. Please drop my Reviewed-by: tag.

Guenter