[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c36hdvkw2ia5g2e6k2jkagux3by453stigjoik2wf7neinfrew@t35ny54nn7gt>
Date: Wed, 30 Aug 2023 17:06:21 +0200
From: Daniel Wagner <dwagner@...e.de>
To: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
Cc: "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
Chaitanya Kulkarni <kch@...dia.com>,
Hannes Reinecke <hare@...e.de>,
Sagi Grimberg <sagi@...mberg.me>,
Jason Gunthorpe <jgg@...pe.ca>,
Bart Van Assche <bvanassche@....org>
Subject: Re: [PATCH blktests v4 3/3] nvme: introduce
nvmet_target_{setup/cleanup} common code
On Wed, Aug 30, 2023 at 01:38:03PM +0000, Shinichiro Kawasaki wrote:
> > diff --git a/tests/nvme/018 b/tests/nvme/018
> > index 68729c3cb070..19e439f3f3e0 100755
> > --- a/tests/nvme/018
> > +++ b/tests/nvme/018
> > @@ -21,16 +21,9 @@ test() {
> >
> > _setup_nvmet
> >
> > - local port
> > local nvmedev
> >
> > - truncate -s "${nvme_img_size}" "${def_file_path}"
> > -
> > - _create_nvmet_subsystem "${def_subsysnqn}" "${def_file_path}" \
> > - "${def_subsys_uuid}"
> > - port="$(_create_nvmet_port "${nvme_trtype}")"
> > - _add_nvmet_subsys_to_port "${port}" "${def_subsysnqn}"
> > - _create_nvmet_host "${def_subsysnqn}" "${def_hostnqn}"
> > + _nvmet_target_setup
>
> As I noted for v3, I think the line above should be,
>
> _nvmet_target_setup --blkdev file
>
> If the change is ok for you, I'll add this fix up and apply the
> series.
Sorry, I didn't see it in the response. Sure thing, no objection from my
side.
Powered by blists - more mailing lists