linux-kernel - Re: [PATCH -next] scsi: fnic: Remove unused function fnic_scsi_host_start/end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd3f2d60-a0e4-4acf-ba1c-3506bc002f94@acm.org>
Date:   Wed, 30 Aug 2023 12:38:56 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Yang Li <yang.lee@...ux.alibaba.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, satishkh@...co.com, sebaddel@...co.com,
        kartilak@...co.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] scsi: fnic: Remove unused function
 fnic_scsi_host_start/end_tag()

On 8/28/23 18:02, Yang Li wrote:
> The function fnic_scsi_host_start_tag() and fnic_scsi_host_end_tag()
> are not used anywhere, so remove them.

Are you sure? I think the following output shows that these are being
used:

$ git grep -nHEw 'fnic_scsi_host_(start|end)_tag'
drivers/scsi/fnic/fnic_scsi.c:2171: * fnic_scsi_host_start_tag
drivers/scsi/fnic/fnic_scsi.c:2175:fnic_scsi_host_start_tag(struct fnic *fnic, struct scsi_cmnd *sc)
drivers/scsi/fnic/fnic_scsi.c:2192: * fnic_scsi_host_end_tag
drivers/scsi/fnic/fnic_scsi.c:2193: * frees tag allocated by fnic_scsi_host_start_tag.
drivers/scsi/fnic/fnic_scsi.c:2196:fnic_scsi_host_end_tag(struct fnic *fnic, struct scsi_cmnd *sc)
drivers/scsi/fnic/fnic_scsi.c:2262:		tag = fnic_scsi_host_start_tag(fnic, sc);
drivers/scsi/fnic/fnic_scsi.c:2439:		fnic_scsi_host_end_tag(fnic, sc);

Bart.