[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9de94c43-5274-4eb3-96b3-a77db2822b92@linaro.org>
Date: Thu, 31 Aug 2023 22:40:39 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Wesley Cheng <quic_wcheng@...cinc.com>,
Marijn Suijten <marijn.suijten@...ainline.org>,
linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,usb-snps-femto-v2: Add REFGEN
regulator
On 31.08.2023 20:25, Rob Herring wrote:
> On Wed, Aug 30, 2023 at 11:13:51PM +0200, Konrad Dybcio wrote:
>> The HSPHY is (or at least can be) one of the users of the reference
>> voltage generating regulator. Ensure that dependency is described
>> properly.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> ---
>> Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
>> index 0f200e3f97a9..e895b6c4ee49 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
>> @@ -53,6 +53,9 @@ properties:
>> items:
>> - description: PHY core reset
>>
>> + refgen-supply:
>> + description: phandle to the REFGEN regulator node
>
> Supply names are local to the device (sink name), but this seems to be
> named based on the supply source. Maybe hard to do if all internal
> stuff. What is this supplying and what's the source if not REFGEN?
I don't think I have anything that would answer this question..
Though I would not at all be surprised if Qualcomm also called the
input "refgen"..
Maybe Bjorn or Dmitry would know.
Konrad
Powered by blists - more mailing lists