linux-kernel - Re: [PATCH v4 5/8] selftests/resctrl: Reorder resctrl FS prep code and benchmark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df92babf-8d41-55ad-e0ed-dae0d7d2f990@intel.com>
Date:   Thu, 31 Aug 2023 14:25:31 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        <linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
        Shaopeng Tan <tan.shaopeng@...fujitsu.com>
CC:     Fenghua Yu <fenghua.yu@...el.com>, Babu Moger <babu.moger@....com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 5/8] selftests/resctrl: Reorder resctrl FS prep code
 and benchmark_cmd init

Hi Ilpo,

On 8/31/2023 4:08 AM, Ilpo Järvinen wrote:
> Benchmark command is initialized before resctrl FS check and
> preparation code that can call ksft_exit_skip(). There is no strong
> reason why the resctrl FS support check and unmounting it (if already
> mounted), has to be done after the benchmark command initialization.
> 
> Move benchmark command initialization such that it is done not until
> right before the tests commence. This simplifies rollback handling when
> benchmark command initialization starts to use dynamic allocation (in a
> change following this).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette