linux-kernel - Re: [PATCH] ata: libata: add workaround to flip LPM during suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202309010504.kO8lW46F-lkp@intel.com>
Date:   Fri, 1 Sep 2023 05:47:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Koba Ko <koba.ko@...onical.com>,
        Damien Le Moal <dlemoal@...nel.org>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH] ata: libata: add workaround to flip LPM during
 suspend/resume

Hi Koba,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.5 next-20230831]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Koba-Ko/ata-libata-add-workaround-to-flip-LPM-during-suspend-resume/20230901-030957
base:   linus/master
patch link:    https://lore.kernel.org/r/20230831190828.1171119-1-koba.ko%40canonical.com
patch subject: [PATCH] ata: libata: add workaround to flip LPM during suspend/resume
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230901/202309010504.kO8lW46F-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230901/202309010504.kO8lW46F-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309010504.kO8lW46F-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/ata/ahci.c:98:12: warning: 'ahci_intel_port_suspend' declared 'static' but never defined [-Wunused-function]
      98 | static int ahci_intel_port_suspend(struct ata_port *ap, pm_message_t mesg);
         |            ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/ata/ahci.c:99:12: warning: 'ahci_intel_port_resume' declared 'static' but never defined [-Wunused-function]
      99 | static int ahci_intel_port_resume(struct ata_port *ap);
         |            ^~~~~~~~~~~~~~~~~~~~~~


vim +98 drivers/ata/ahci.c

    82	
    83	static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
    84	static void ahci_remove_one(struct pci_dev *dev);
    85	static void ahci_shutdown_one(struct pci_dev *dev);
    86	static void ahci_intel_pcs_quirk(struct pci_dev *pdev, struct ahci_host_priv *hpriv);
    87	static int ahci_vt8251_hardreset(struct ata_link *link, unsigned int *class,
    88					 unsigned long deadline);
    89	static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
    90				      unsigned long deadline);
    91	static void ahci_mcp89_apple_enable(struct pci_dev *pdev);
    92	static bool is_mcp89_apple(struct pci_dev *pdev);
    93	static int ahci_p5wdh_hardreset(struct ata_link *link, unsigned int *class,
    94					unsigned long deadline);
    95	#ifdef CONFIG_PM
    96	static int ahci_pci_device_runtime_suspend(struct device *dev);
    97	static int ahci_pci_device_runtime_resume(struct device *dev);
  > 98	static int ahci_intel_port_suspend(struct ata_port *ap, pm_message_t mesg);
  > 99	static int ahci_intel_port_resume(struct ata_port *ap);
   100	#ifdef CONFIG_PM_SLEEP
   101	static int ahci_pci_device_suspend(struct device *dev);
   102	static int ahci_pci_device_resume(struct device *dev);
   103	#endif
   104	#endif /* CONFIG_PM */
   105	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki