[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <720d11fc-aad9-41de-54db-8ebc1a06e336@huaweicloud.com>
Date: Thu, 31 Aug 2023 11:51:44 +0800
From: "Leizhen (ThunderTown)" <thunder.leizhen@...weicloud.com>
To: Baoquan He <bhe@...hat.com>, linux-kernel@...r.kernel.org
Cc: akpm@...ux-foundation.org, catalin.marinas@....com,
thunder.leizhen@...wei.com, dyoung@...hat.com, prudo@...hat.com,
samuel.holland@...ive.com, kexec@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, x86@...nel.org
Subject: Re: [PATCH v2 8/8] crash_core.c: remove unneeded functions
On 2023/8/29 20:16, Baoquan He wrote:
> So far, nobody calls functions parse_crashkernel_high() and
> parse_crashkernel_low(), remove both of them.
Reviewed-by: Zhen Lei <thunder.leizhen@...wei.com>
>
> Signed-off-by: Baoquan He <bhe@...hat.com>
> ---
> include/linux/crash_core.h | 4 ----
> kernel/crash_core.c | 18 ------------------
> 2 files changed, 22 deletions(-)
>
> diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h
> index 86e22e6a039f..d64006c4bd43 100644
> --- a/include/linux/crash_core.h
> +++ b/include/linux/crash_core.h
> @@ -83,10 +83,6 @@ void final_note(Elf_Word *buf);
> int __init parse_crashkernel(char *cmdline, unsigned long long system_ram,
> unsigned long long *crash_size, unsigned long long *crash_base,
> unsigned long long *low_size, bool *high);
> -int parse_crashkernel_high(char *cmdline, unsigned long long system_ram,
> - unsigned long long *crash_size, unsigned long long *crash_base);
> -int parse_crashkernel_low(char *cmdline, unsigned long long system_ram,
> - unsigned long long *crash_size, unsigned long long *crash_base);
>
> #ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> #ifndef DEFAULT_CRASH_KERNEL_LOW_SIZE
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 6bc00cc390b5..61a8ea3b23a2 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -323,24 +323,6 @@ int __init parse_crashkernel(char *cmdline,
> return 0;
> }
>
> -int __init parse_crashkernel_high(char *cmdline,
> - unsigned long long system_ram,
> - unsigned long long *crash_size,
> - unsigned long long *crash_base)
> -{
> - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base,
> - suffix_tbl[SUFFIX_HIGH]);
> -}
> -
> -int __init parse_crashkernel_low(char *cmdline,
> - unsigned long long system_ram,
> - unsigned long long *crash_size,
> - unsigned long long *crash_base)
> -{
> - return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base,
> - suffix_tbl[SUFFIX_LOW]);
> -}
> -
> /*
> * Add a dummy early_param handler to mark crashkernel= as a known command line
> * parameter and suppress incorrect warnings in init/main.c.
>
--
Regards,
Zhen Lei
Powered by blists - more mailing lists